Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: remove ldconfig -n. #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

haampie
Copy link

@haampie haampie commented Apr 11, 2022

ldconfig can't be assumed to be available.

ldconfig -n /tmp/spack-stage/spack-stage-gdrcopy-2.3-lxw353euu26enjkcctzbux6n6cj3wjgt/spack-src/src
make[1]: ldconfig: Command not found
make[1]: *** [Makefile:60: libgdrapi.so.2.3] Error 127
cat /etc/os-release 
NAME="SLES"
VERSION="15-SP2"
VERSION_ID="15.2"
PRETTY_NAME="SUSE Linux Enterprise Server 15 SP2"

`ldconfig` can't be assumed to be available.

```
ldconfig -n /tmp/spack-stage/spack-stage-gdrcopy-2.3-lxw353euu26enjkcctzbux6n6cj3wjgt/spack-src/src
make[1]: ldconfig: Command not found
make[1]: *** [Makefile:60: libgdrapi.so.2.3] Error 127
```

```
cat /etc/os-release 
NAME="SLES"
VERSION="15-SP2"
VERSION_ID="15.2"
PRETTY_NAME="SUSE Linux Enterprise Server 15 SP2"
```
@e4t
Copy link
Contributor

e4t commented Jul 22, 2023

You cannot remove the call to ldconfig here or it will come back to haunt you later when linking against libgdrapi when building the tests.
The reason why it's not found is that it is located under /sbin. Have a look at this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants